Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/predefined configs #28

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Keyrxng
Copy link
Contributor

@Keyrxng Keyrxng commented Nov 22, 2024

Resolves #22
Requires #25

Changes:

  • template selection step
  • minimal config: I've copied an org installed config but we could create minimal-config.yml in a marketplace repo (.ubiquity-os?) and just fetch it from there instead, this would be prefer imo as it's easier to edit than baked into the build.
  • full defaults: I've implemented the schema provided defaults as best we can right now some plugins need updated (see manifest.name mismatch #27)

QA:

templates.mp4

@rndquu rndquu self-requested a review November 29, 2024 16:02
Copy link
Member

@rndquu rndquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On yarn start getting the same errors as in this CI run.

Pls fix both failing build and cypress workflows.

Copy link

@Keyrxng, this task has been idle for a while. Please provide an update.

1 similar comment
Copy link

@Keyrxng, this task has been idle for a while. Please provide an update.

@ubiquity-os-beta ubiquity-os-beta bot closed this Dec 15, 2024
@Keyrxng
Copy link
Contributor Author

Keyrxng commented Dec 20, 2024

@rndquu I can't re-open, would you mind doing it for my PRs in this repo. Sorry for the inactivity, been dealing with a bereavement.

@rndquu rndquu reopened this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Predefined configs
2 participants